Re: [Emacs-diffs] master 55ec674: * lisp/multifile.el: New file, extracted from etags.el

[Dmitry Gutov]

On 02.01.2019 4:49, Stefan Monnier wrote:

> No idea, sorry.  What do the 2 profiles look like?

project-find-regexp:

- benchmark-elapse                                         118  36%
 - let                                                     118  36%
  - dotimes                                                118  36%
   - let                                                   118  36%
    - while                                                118  36%
     - let                                                 118  36%
      - project-find-regexp                                118  36%
       - let*                                              118  36%
        - project--find-regexp-in                           94  29%
         - let*                                             82  25%
          - cl-mapcan                                       58  17%
           - mapcan                                         58  17%
            - #<lambda 0x52c9c08662ddee3>                   58  17%
             - xref-collect-matches                         58  17%
              - let*                                        38  11%
               - xref--rgrep-command                        27   8%
                - grep-expand-template                      20   6%
                 - xref--find-ignores-arguments                 16
                  - if                                      16   4%
                   - progn                                  16   4%
                    - concat                                16   4%
                     - mapconcat                            16   4%
                      - #<lambda 0x18e11839a266d1eb>
                       - shell-quote-argument                 16   4
                        - replace-regexp-in-string                 1
                           apply                             4   1%
                 + eval                                      4   1%
                + require                                    7   2%
               + let                                        11   3%
              + project-ignores                             12   3%
              + require                                      4   1%
          - xref--show-xrefs                                24   7%
           - cond                                           24   7%
            - funcall                                       24   7%
             - xref--show-xref-buffer                       24   7%
              - let                                         24   7%
               + save-current-buffer                        24   7%
         + require                                          12   3%
        + project-current                                   24   7%

project-files-pipe-grep, the latest version:

- benchmark-elapse                                              235  11%
 - let                                                          235  11%
  - dotimes                                                     235  11%
   - let                                                        235  11%
    - while                                                     235  11%
     - let                                                      235  11%
      - project-files-pipe-grep                                 235  11%
       - let*                                                   235  11%
        - let                                                   118   5%
         - let*                                                 118   5%
          - cons                                                113   5%
           - cons                                               113   5%
            - cons                                              113   5%
             - append                                           113   5%
              - list                                            113   5%
               - -                                              109   5%
                - benchmark-elapse                              109   5%
                ^
(the output is weird here)
                 - let                                          109   5%
                  + dotimes                                     109   5%
               - shell-quote-argument                             4   0%
                - xref--regexp-to-extended                        4   0%
                   replace-regexp-in-string                       4   0%
          - progn                                                 5   0%
           - save-current-buffer                                  5   0%
            - if                                                  5   0%
             - and                                                5   0%
                not                                               5   0%
        - project-files                                         117   5%
         + progn                                                 94   4%
         + project-current                                       23   1%

project-files-pipe-grep, the version with temporary file:

- benchmark-elapse                                           140   6%
 - let                                                       140   6%
  - dotimes                                                  140   6%
   - let                                                     140   6%
    - while                                                  140   6%
     - let                                                   140   6%
      - project-files-pipe-grep                              140   6%
       - let*                                                140   6%
        - project-files                                       88   3%
         - progn                                              83   3%
          - all-completions                                   83   3%
           - project-file-completion-table                    83   3%
            - progn                                           83   3%
             - progn                                          83   3%
              - let                                           83   3%
               - cl-mapcan                                    83   3%
                - mapcan                                      83   3%
                 - #<lambda 0xd6ae159f08a7db4>                 83   3%
                  - let                                       83   3%
                   + format                                   45   2%
                   + split-string                             34   1%
         + project-current                                     5   0%
        - let                                                 52   2%
         - let*                                               52   2%
          - progn                                             52   2%
           + xref--show-xrefs                                 29   1%
           + let                                              19   0%
           + save-current-buffer                               4   0%

Not sure what we could read from any of this.