[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: open-{gnutls,network}-stream backwards compatibility

From: Eli Zaretskii
Subject: Re: open-{gnutls,network}-stream backwards compatibility
Date: Sat, 12 Jan 2019 13:16:29 +0200

> From: Robert Pluim <address@hidden>
> Date: Wed, 09 Jan 2019 22:50:13 +0100
> Robert Pluim <address@hidden> writes:
> >> Sounds OK to me, provided we announce this in NEWS.
> >
> > Nah, we'll spring it on the users unannounced and see what happens :-)
> Proposed changes, on top of the proposed patch for Bug#33780.

Both LGTM, with the minor comments fixed.

> +(defcustom network-stream-use-client-certificates t
> +  "Whether to use client certificates for network connections.

Please add a :version tag to this defcustom.

> +When non-nil, `open-network-stream' will automatically look for
> +matching client certificates (via 'auth-source') for a
> +destination server, if it is called without a :client-certificate
> +keyword.  Default is t.
No need to state that, as Emacs knows that automatically.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]