[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

some accept-process-output races fixed; Tramp FIXMEs

From: Paul Eggert
Subject: some accept-process-output races fixed; Tramp FIXMEs
Date: Tue, 15 Jan 2019 10:33:43 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

I've been annoyed for months that test/src/process-tests.el occasionally failed on my work desktop, and finally got annoyed enough to track it down. It was a race condition bug, fixed in the attached patch. I looked for similar instances of the bug elsewhere in Emacs, and found what appear to be some instances in Tramp code, along with some mysterious "0.1"s that may be inadequate attempts to work around the bug. I installed the attached patch to try to document and fix this mess, including some FIXMEs about those "0.1"s; I hope Michael or someone else with Tramp expertise (I don't use Tramp) can take a look at those FIXMEs and at my other Tramp changes, and perhaps at all other Tramp uses of accept-process-output and of tramp-accept-process-output.

Now that I'm thinking about it, I should also mention that a single (accept-process-output P) is not guaranteed to slurp all the data from process P even if P has already exited. Just a word to the wise....

Attachment: 0001-Fix-accept-process-output-process-live-p-confusion.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]