[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests whi

From: João Távora
Subject: Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it.
Date: Thu, 17 Jan 2019 18:55:34 +0000

> > Anyhow, apologies, and all that, but I don't want to spend any more time
> > on this topic today or until tomorrow evening, since I've got an exam
> > coming up tomorrow.  But I promise I'll get back to you (including
> > answering your other post) either late tomorrow or on Saturday.
> Alright. Good luck for your exam.
> In the meantime. I will have to fix this differently. I will add a
> temporary variable that I can set to have sane C++ behaviour
> in the meantime. I will set this variable when running tests, so
> the test people will see correct results.

This is done in 4bdc03746915c36313b33b6998b855eef514cdd1 and

The fix for bug#33794 can now be disabled by setting a variable
to t.  The variable's default value is nil, so the fix is in place
and so are all the problems that come with it.

Meanwhile, users of c-mode and c++-mode can:

   (setq c--disable-fix-of-bug-33794 t)

if they don't care about the fix for bug#33794, which only
affects users of c-toggle-auto-newline, off by default.

Thanks again,

commit be505726b68d407a44fdcd9c7ac1ef722398532d
Date:   Thu Jan 17 18:47:00 2019 +0000

    Fix electric-pair-tests by disabling bug#33794's fix with a variable

    The variable c--disable-fix-of-bug-33794, which should be removed in
    the short term in favor of a permanent solution, is introduced.

    It is bound to nil by default.  This means that breakage is still
    happening in actual c-mode and c++-mode usage, though the tests no
    longer show it.

    To get around this breakage, put

       (setq c--disable-fix-of-bug-33794 t)

    In your init file.  Evidently, you will lose the fix for bug#33794,
    but that only affects a small corner case of c-toggle-auto-newline,
    which is not turned on by default.

    See https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00360.html
    for more information.

    * lisp/progmodes/cc-cmds.el (c--disable-fix-of-bug-33794): New
    (c--with-post-self-insert-hook-maybe): New macro.
    (c-electric-pound, c-electric-brace, c-electric-slash)
    (c-electric-star, c-electric-semi&comma, c-electric-colon)
    (c-electric-lt-gt, c-electric-paren): Use it.
    (c-electric-paren, c-electric-brace): Check

    * test/lisp/electric-tests.el (c--disable-fix-of-bug-33794):
    Forward declare.
    (electric-modes-in-c-mode-with-self-insert-command): Use it.

commit 4bdc03746915c36313b33b6998b855eef514cdd1
Date:   Thu Jan 17 18:08:01 2019 +0000

    Revert "Temporarily comment out CC Mode from tests..."

    This reverts commit 54f297904e0c641fcfd81f16e9a87177124a27be.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]