[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c

From: Paul Eggert
Subject: Re: [Emacs-diffs] master 8e2b2a2: Minor cleanup in pdumper.c
Date: Mon, 21 Jan 2019 23:24:29 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Daniel Colascione wrote:
Thanks, I had forgotten about timespectod. I installed the attached. Yay, one less use of ALLOW_IMPLICIT_CONVERSION, a macro I'm not a fan of.

It beats trying to debug silent integral truncation problems without compiler help. IMHO, it was a mistake for C to allow silent destructive narrowing conversion.

In my experience the warning is more trouble than it's worth in Emacs source code, as its signal-to-noise ratio is too large there. There are no free lunches in software development, and this particular lunch goes waaayyy over budget.

Although I also would like to go back to 1975 and whisper advice in Thompson & Ritchie's ears, it's a bit late for that now. Besides, they would have disagreed with me anyway, and with you too. (Some years later I argued with Ritchie on the topic of C's integer widths and promotions, and failed to convince him.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]