[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring f
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump |
Date: |
Mon, 28 Jan 2019 20:14:00 +0200 |
> From: Daniel Colascione <address@hidden>
> Date: Mon, 28 Jan 2019 08:05:13 -0800
>
> On 1/28/19 7:25 AM, Eli Zaretskii wrote:
> > branch: master
> > commit cd06d173a602bf0aa8a227ff1626dc70013fe480
> > Author: Eli Zaretskii <address@hidden>
> > Commit: Eli Zaretskii <address@hidden>
> >
> > Fix bug with face-id after restoring from pdump
>
> I was going to fix this problem by just turning lface_id_to_name into a
> normal Lisp vector and using its size as the next face ID. Why use this
> more complicated approach?
Based on previous discussion regarding frames and faces, I was under
the impression that you prefer moving stuff to the startup of emacs.
I'm not wed to my solution, feel free to change if you think it's
better.