[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix `early-init-file' value when file is missing
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] Fix `early-init-file' value when file is missing |
Date: |
Fri, 08 Feb 2019 09:32:55 +0200 |
> From: Radon Rosborough <address@hidden>
> Date: Fri, 1 Feb 2019 15:10:24 -0800
> Cc: emacs-devel <address@hidden>
>
> > This patch has the (possibly unintended) consequence that if ~/.emacs
> > doesn't exist, user-init-file is set to "~/.emacs.el", something I
> > don't think we want. Can you propose a change that will affect only
> > early-init-file, not any other init file?
>
> Sure, no problem. I apologize for the oversight.
>
> A revised patch which implements the same bugfix without changing the
> value of `user-init-file' is attached.
>
> Previously, if no early init-file existed in `user-emacs-directory',
> then the value of `early-init-file' after startup would be
> ~/.emacs.d/early-init (note the missing extension). This commit
> adjusts that value to ~/.emacs.d/early-init.el as desired, while not
> changing other behavior. Note that when the early init-file did
> exist, then the value of `early-init-file' after startup was already
> correct; this commit fixes a bug that occurred only when the file did
> not exist.
>
> lisp/startup.el (load-user-init-file): Update logic.
Thanks. However, I would prefer to have this solved outside
load-user-init-file, if feasible. This function is too central to
Emacs to make non-trivial changes there for such a minor problem's
sake. Especially since we don't have a test suite for startup
functionalities. I think the change outside of the function will also
be much simpler and thus easier to grasp.
- Re: [PATCH] Fix `early-init-file' value when file is missing, Eli Zaretskii, 2019/02/01
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/01
- Re: [PATCH] Fix `early-init-file' value when file is missing,
Eli Zaretskii <=
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/08
- Re: [PATCH] Fix `early-init-file' value when file is missing, Eli Zaretskii, 2019/02/08
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/10
- Re: [PATCH] Fix `early-init-file' value when file is missing, Stefan Monnier, 2019/02/10
- Re: [PATCH] Fix `early-init-file' value when file is missing, Eli Zaretskii, 2019/02/11
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/12
- Re: [PATCH] Fix `early-init-file' value when file is missing, Eli Zaretskii, 2019/02/12
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/12
- Re: [PATCH] Fix `early-init-file' value when file is missing, Eli Zaretskii, 2019/02/13
- Re: [PATCH] Fix `early-init-file' value when file is missing, Radon Rosborough, 2019/02/15