[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ELPA] New package proposal: visual-path-abbrev.el
From: |
Tassilo Horn |
Subject: |
Re: [ELPA] New package proposal: visual-path-abbrev.el |
Date: |
Sat, 02 Mar 2019 15:59:00 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eli Zaretskii <address@hidden> writes:
Hi Eli,
> The GNU Coding Style conventions frown on using "path" for anything
> but PATH-style directory lists. I think you mean "file names" here.
Fine with me.
>> - Sometimes when scrolling fast and then stopping, only parts of the
>> visible buffer portion got the overlays applied. You can try
>> triggering that problem by enabling the mode in a *grep* buffer and
>> then scrolling a long way.
>
> Your code seems to update the overlays in a function called from
> post-command-hook, but post-command-hook runs before redisplay updates
> the window due to last command. So you are using stale window-start
> and window-end values, and if the last command scrolls some file names
> into the view, those file names might not have overlays on them.
>
> I think the preferred method is to use jit-lock-register to register
> your function; see e.g. glasses.el for how this can be done.
Yes, that looks good. I'll try that out.
>> - When lines are wrapped around and line-move-visual is t, the mode can
>> make the line short enough so that it doesn't wrap anymore. But
>> still next-line moves point to where it would belong if the mode were
>> not active, i.e., point jumps to somewhere on the same line.
>
> That sounds like a bug, so a minimal recipe to reproduce this (in a
> bug report, please ;-) would be appreciated.
Ok, I'll do that.
Bye,
Tassilo
- [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/02
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Eli Zaretskii, 2019/03/02
- Re: [ELPA] New package proposal: visual-path-abbrev.el,
Tassilo Horn <=
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Stefan Monnier, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Eli Zaretskii, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Eli Zaretskii, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/03
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Eli Zaretskii, 2019/03/04
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/05
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Eli Zaretskii, 2019/03/05
- Re: [ELPA] New package proposal: visual-path-abbrev.el, Tassilo Horn, 2019/03/05