[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Scan of regexp mistakes
From: |
Mattias Engdegård |
Subject: |
Re: Scan of regexp mistakes |
Date: |
Tue, 5 Mar 2019 17:12:41 +0100 |
5 mars 2019 kl. 16.35 skrev Wilson Snyder <address@hidden>:
>
> Paul et al, thanks for this cleanup:
>
>> * commit 3c94c7bc02fcacb4a101188dddb0c44d53444178
>> Author: Paul Eggert <address@hidden>
>> Fix regular-expression glitches and typos
>
> This though failed the verilog-mode.el internal tests due to this:
>
>> -
>> "\\s-*\\.\\(\\(address@hidden|---]\\|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(.*\\))\\s-*\\(,\\|)\\s-*;\\)")
>> +
>> "\\s-*\\.\\(\\(address@hidden|[][]\\|\\\\[()|]\\)+\\)\\s-*(\\(.*\\))\\s-*\\(,\\|)\\s-*;\\)")
>
> Which removed | from the character class. I committed a fix for this, but
> you may want to check the other files patched.
-(defconst verilog-coverpoint-re
"\\w+\\s-*:\\s-*\\(coverpoint\\|cross\\constraint\\)" )
+(defconst verilog-coverpoint-re
"\\w+\\s*:\\s*\\(coverpoint\\|cross\\|constraint\\)")
I don't think "\\s*" matches anything, since * is not a syntax class character.
The regexp engine doesn't complain, but it probably should. What do you want it
to match?
- Re: Scan of regexp mistakes, (continued)
- Re: Scan of regexp mistakes, Clément Pit-Claudel, 2019/03/04
- Re: Scan of regexp mistakes, Mattias Engdegård, 2019/03/05
- Re: Scan of regexp mistakes, Mattias Engdegård, 2019/03/09
- Re: Scan of regexp mistakes, Paul Eggert, 2019/03/09
- Re: Scan of regexp mistakes, Mattias Engdegård, 2019/03/09
Re: Scan of regexp mistakes, Wilson Snyder, 2019/03/05