emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?


From: Tadeus Prastowo
Subject: Re: Do you really mean to call `cl--generic-prefill-dispatchers' twice?
Date: Thu, 4 Apr 2019 19:14:51 +0200

On Thu, Apr 4, 2019 at 6:04 PM Stefan Monnier <address@hidden> wrote:
>
> > While looking at the diff of commit
> > cd1d9e79f74f137511d49eb9b0ae7ba750ba6c3c, I see the following hunk:
> > -- 8< ----------------------
> > @@ -1205,6 +1209,7 @@ See the full list and their hierarchy in
> > `cl--generic-typeof-types'."
> >     (cl-call-next-method)))
> >
> >  (cl--generic-prefill-dispatchers 0 integer)
> > +(cl--generic-prefill-dispatchers 0 cl--generic-generalizer integer)
> >
> >  ;;; Dispatch on major mode.
> >
> > -- 8< ----------------------
> >
> > Why didn't you delete the first call `(cl--generic-prefill-dispatchers
> > 0 integer)'?
>
> Either because:
> - There are still methods defined in the preloaded packages which do
>   dispatch on a first argument that's `integer`.
> - I didn't bother to check whether there are still such methods.
> I can't remember which.  If you've check that there aren't such methods
> left, then we could remove it, indeed.

Thank you very much for your comment.  I wanted to make sure that the
line was not left by accident.

>         Stefan

-- 
Best regards,
Tadeus



reply via email to

[Prev in Thread] Current Thread [Next in Thread]