Re: [PATCH] Add a new user option 'ido-big-directories'.

[Óscar Fuentes]

Philipp Stephani <address@hidden> writes:

> Am Mi., 17. Apr. 2019 um 20:58 Uhr schrieb Óscar Fuentes <address@hidden>:
>>
>> Philipp Stephani <address@hidden> writes:
>>
>> > This provides an alternative to 'ido-max-directory-size', for
>> > directories that are statically known to be too big for Ido
>> > completion.
>> >
>> > * lisp/ido.el (ido-big-directories): New user option.
>> > (ido-directory-too-big-p): Use it.
>>
>> What this option does is to revert to non-ido completion when the
>> regexp matches the directory name, it has nothing to do with the
>> directory being big.
>>
>> I suggest that you rename the user option accordingly and move its use
>> outside of ido-directory-too-big-p.
>
> This is a semantical difference: it's specifically intended to mark
> directories as big, and Ido shows "too big" when attempting to
> complete such a directory, so I think the name is warranted.

Since this feature depends on name matching and nothing else, presuming
that its only use is for signaling big directories is projecting your
motivations for implementing it on the rest of the users' needs.

No functionality is lost by turning this from "switch off ido for
directories whose name matches this regexp because they are big" into
"switch off ido for directories whose name matches this regexp". Using
the appropriate name for the defcustom and placing the check on a more
general site you can convey the full applicability of the feature.

My 0.02 cents.