emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 4b39b74: python.el: don't syntax-propertize single/double quo


From: Andreas Röhler
Subject: Re: master 4b39b74: python.el: don't syntax-propertize single/double quoted strings
Date: Fri, 26 Apr 2019 10:12:06 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Thunderbird/60.6.1



On 11.04.19 01:59, Noam Postavsky wrote:
On Wed, 10 Apr 2019 at 11:18, Clément Pit-Claudel <address@hidden> wrote:

This causes python-tests--python-nav-end-of-statement--infloop to fail.
Hmm... I can't find a better way than to disable it, sorry.
But that test was added to prevent regression of an actual bug, right?
Did your commit reintroduce the bug? If so, disabling the test doesn't sound 
ideal…
I think the related report is Bug#30964, but there was never a clear
reproducer for it. The commit that introduced the test is [1: 4fbd330fae],
whose commit message says: "[...] Unfortunately it is
impossible to reproduce without manually destroying the syntactic
information in the Python buffer, but it has been observed in
practice [...]".

[1: 4fbd330fae]: 2017-03-23 23:05:19 +0100
   Protect against an infloop in python-mode
   
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=4fbd330fae54a9c45d4a717127aa86d75e9938d5


Hi,

if syntax-ppss is the cause, than that kind of bug is sourced in other places/modes too. As fixing syntax-ppss seems difficult, being interested to learn about cases, where it can't be replaced by calls to parse-partial-sexp.

Best,

Andreas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]