emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Renaming non-X x_* identifiers


From: Basil L. Contovounesios
Subject: Re: [PATCH] Renaming non-X x_* identifiers
Date: Sat, 27 Apr 2019 02:53:34 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> From 55a39c6cb4eb9a1442dd3388766f0219bf8cd825 Mon Sep 17 00:00:00 2001
> From: Alexander Gramiak <address@hidden>
> Date: Sat, 13 Apr 2019 09:40:03 -0600
> Subject: [PATCH 3/5] Rename non-X x_* identifiers

[...]

> * src/dispextern.h (clear_under_internal_border): New RIF function
> pointer.

[...]

> diff --git a/src/xdisp.c b/src/xdisp.c
> index ae4c405b8d..11667d2735 100644
> --- a/src/xdisp.c
> +++ b/src/xdisp.c
> @@ -11592,9 +11592,8 @@ clear_garbaged_frames (void)
>             else
>               clear_current_matrices (f);
>  
> -#if defined (HAVE_WINDOW_SYSTEM) && !defined (HAVE_NS)
> -           x_clear_under_internal_border (f);
> -#endif /* HAVE_WINDOW_SYSTEM && !HAVE_NS */
> +              if (FRAME_RIF (f)->clear_under_internal_border)
> +                FRAME_RIF (f)->clear_under_internal_border (f);
>  
>             fset_redisplay (f);
>             f->garbaged = false;

This causes a segfault in 'emacs -nw' and emacsclient because
FRAME_RIF (f) is NULL in tty frames such as the initial daemon frame.
Is x_clear_under_internal_border not supposed to be run in tty frames?

Thanks,

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]