emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF fo


From: Stefan Monnier
Subject: Re: [Emacs-diffs] master f257a0a: * src/xdisp.c: Only check FRAME_RIF for graphical frames
Date: Sun, 28 Apr 2019 21:50:21 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> -              if (FRAME_RIF (f)->clear_under_internal_border)
> +              if (FRAME_WINDOW_P (f)
> +                  && FRAME_RIF (f)->clear_under_internal_border)

Wouldn't testing FRAME_RIF(f) instead of FRAME_WINDOW_P(f) make
more sense?  At least, it would not rely on the fact that FRAME_RIF(f)
is supposedly non-NULL when FRAME_WINDOW_P(f) is true.

It'd make the code more "obviously safe".


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]