emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte b


From: Stefan Monnier
Subject: Re: emacs-26 8f18d12: Improve documentation of decoding into a unibyte buffer
Date: Mon, 27 May 2019 23:08:36 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> Since this is the underlying code that displays the 'buffer code'
> section of 'C-u C-x =', I donʼt think barfing on multibyte is the
> right thing to do. Nor is passing it on as is.

grep gives me:

    % grep --color -nH --null -e encoded-string-description **/*.el
    descr-text.el\0350:   (encoded-string-description encoded coding)))))
    descr-text.el\0645:                    (encoded-string-description
    descr-text.el\0655:                           (list 
(encoded-string-description encoded coding)
    international/mule-cmds.el\02900:(defun encoded-string-description (str 
coding-system)
    simple.el\01481:                            (encoded-string-description 
encoded coding)))

and according to my quick investigation, all callers pass a string
that's coming straight from encode-coding-string or encode-coding-char,
so the argument should *always* be unibyte, AFAICT.

Hence according to my reading of the code, this call to
string-as-unibyte will always just return its argument unchanged.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]