[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: send new reply from gnus hangs
From: |
Óscar Fuentes |
Subject: |
Re: send new reply from gnus hangs |
Date: |
Fri, 14 Jun 2019 15:42:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) |
Eric Abrahamsen <address@hidden> writes:
> Okay, that worked!
>
> What does everyone think of the attached diff? It moves the
> `message-check' call out of the internal function (that seems like work
> that should be done by the caller, not the internal function, and helps
> the call fit in visually), and either returns nil or errors depending on
> an optional arg.
I have no time now to review the code (and I'm not familiar with Gnus'
code base) but I was going to propose reverting the problematic commit.
If your patch solves the problem, great. If there are doubts, the right
thing is reverting.
There is no justification for having master in an unusable state (if you
are a Gnus user) for more than a week due to a cosmetic change like
this.
- Re: send new reply from gnus hangs, (continued)
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Robert Pluim, 2019/06/10
- Re: send new reply from gnus hangs, Andy Moreton, 2019/06/10
- Re: send new reply from gnus hangs, Eric Abrahamsen, 2019/06/13
- Re: send new reply from gnus hangs, Eric Abrahamsen, 2019/06/13
- Re: send new reply from gnus hangs,
Óscar Fuentes <=
- Re: send new reply from gnus hangs, Eric Abrahamsen, 2019/06/14
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09
- Re: send new reply from gnus hangs, Óscar Fuentes, 2019/06/09