emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Unbreak build on macOS


From: Mattias Engdegård
Subject: Unbreak build on macOS
Date: Tue, 9 Jul 2019 13:41:57 +0200

On macOS, lib/fcntl.h does

#   define open rpl_open

which now (f8ab90839f) gets included in src/font.c and breaks the line

      font_object = driver_list->driver->open (f, entity, psize);

As an immediate remedy, I added

#undef open

to src/font.c.

In general, '#define open' is a rather unpleasant thing to do. Can we at least 
assume enough of C99 to do

#define open(...) rpl_open (__VA_ARGS__)

instead? That would permit font.c to use bracketing as an alternative 
countermeasure.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]