[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 7 logical-xor implementations in source tree

From: Basil L. Contovounesios
Subject: Re: 7 logical-xor implementations in source tree
Date: Fri, 02 Aug 2019 13:59:59 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Mattias Engdegård <address@hidden> writes:

> 1 aug. 2019 kl. 01.39 skrev Basil L. Contovounesios <address@hidden>:
>> Thanks, LGTM except for some minor nits:
> Thank you! I've fixed them all according to your suggestions, clarified a few
> more things here and there (mentioning the slight change of semantics of `xor'
> in NEWS), and attached the revised patch.
> However, given that the naming and desirability of `equiv' are (amicably)
> disputed, I thought it prudent to prepare a reduced patch with `xor' only, as 
> an
> incremental step if nothing else.

Either looks and sounds good to me.

[Not sure if this is customary, but now that the month has changed,
 perhaps the log entry could additionally link to the 2019-08 part of
 this emacs-devel thread.]

>>> +(when (equiv enabled disable)
>>> +  ;; Toggle state
>>> +  @dots{})
>> [I would love to see a better and less forced example than this, BTW.]
> Replaced with another example -- perhaps no better; you be the judge.

I prefer your example, it's simpler and needs less explaining.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]