[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55:

From: Paul Eggert
Subject: Re: Changes in GC and in pure space (was: [Emacs-diffs] master 5d4dd55: Fix lifetime error in previous patch)
Date: Wed, 21 Aug 2019 22:36:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

Here are things I would consider urgent enough to warrant looking at
for Emacs 27:
- remove code like we have in `Ffset' to detect GC bugs that
presumably have been fixed by now

Are you talking about just the code introduced in commit
(01ae0fbf30b74e2490144fceabbf5bc5d96f1ba7), or is some other code involved? I'll
CC this to dancol to see if he has thoughts.

There's also reference to a GC bug in describe_vector.

Thanks for mentioning these two items. I installed the attached two patches into master. The first arranges for SUSPICIOUS_OBJECT_CHECKING to not be defined unless one compiles with ENABLE_CHECKING, which should remove the Ffset hack in production code; the second removes that 25-year-old GC workaround that hasn't been needed for quite some time.

Actually, all that SUSPICIOUS_OBJECT_CHECKING code can be removed. But one step at a time.

Attachment: 0001-Don-t-debug-fset-by-default.patch
Description: Text Data

Attachment: 0002-Remove-no-longer-needed-workaround-for-GC-bug.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]