[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs regexp scan (Sep 29)

From: Mattias Engdegård
Subject: Re: Emacs regexp scan (Sep 29)
Date: Sat, 5 Oct 2019 12:03:45 +0200

4 okt. 2019 kl. 23.42 skrev Paul Eggert <address@hidden>:
> Thanks, I installed the attached patch, which I hope fixes all the bugs and 
> style glitches uncovered by that scan, along with some other style glitches I 
> noticed in the neighborhood.

Thank you, I've reviewed it and found no errors. I also grepped for similar 
mistakes (missing \ or u in Unicode escapes) but didn't find anything else.

Just a small complaint remaining:

 (defconst gurmukhi-composable-pattern
-          ("Y" . "[\u0A2F-u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
+          ("Y" . "[\u0A2F-\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA

The hyphen can be removed.

(You can run the checker yourself by installing the `relint' package from GNU 
ELPA, and running
M-x relint-directory RET <Emacs source dir> RET.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]