Re: add-face-text-property destructively modified properties

[Lars Ingebrigtsen]

Stefan Monnier <address@hidden> writes:

>> Up until yesterday, using this function on copies of strings would
>> modify the original string:
>
> Indeed.  There was an open bug report about that (sorry, don't have the
> bug-nb at hand).

Yup; it was that bug report that made me change the behaviour.

>> Eli wanted comments about whether anybody thinks this is a surprising
>> change.
>
> I think it was a plain bug.  The old behavior was
> definitely surprising. 
>
> What is surprising about the change is that it took so long to come ;-)

When I added add-face-text-property, it was for shr, which only uses it
for buffers where this isn't a problem (I think...?), so I probably
didn't even consider how this would work in strings.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no