emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master e21a1da: Allow completion styles to adjust completion metadat


From: João Távora
Subject: Re: master e21a1da: Allow completion styles to adjust completion metadata
Date: Sat, 26 Oct 2019 23:03:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

>> +    (when adjust-fn
>> +      (setcdr metadata (cdr (funcall adjust-fn metadata))))
>
> Do we know that the `metadata` argument we received is always a cons
> cells?

I assumed it is.  Do you know that it isn't?  nil?  BTW I hate this
metadata object, I with there were proper writers/constructors that
didn't assume anything about its cons-implementation.  Perhaps I missed
something.

> BTW, I just changed the bootstrap so that cl-defgeneric should now be
> usable in minibuffer.el.

Out of energy right now.  Be my guest, the switch to cl-generic is
trivally outlined in the now-revert commit.

João




reply via email to

[Prev in Thread] Current Thread [Next in Thread]