emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: python: Let pdb tracking not kill buffers


From: Eli Zaretskii
Subject: Re: python: Let pdb tracking not kill buffers
Date: Sat, 02 Nov 2019 19:29:09 +0200

> From: Andrii Kolomoiets <address@hidden>
> Date: Sat, 2 Nov 2019 18:37:26 +0200
> Cc: address@hidden
> 
> On 1 Nov 2019, at 11:35, Eli Zaretskii <address@hidden> wrote:
> > Can you please add:
> > 
> >  . Commit log message formatted according to instructions in
> >    CONTRIBUTE
> >  . Suitable short entry for NEWS about the new options
> 
> Please see attached updated patch.

Thanks.

> Current python-pdbtrack-stacktrace-info-regexp match only lines with real
> filenames, like:
>   > /Users/mad/test.py(3)<module>()->None
> 
> Pdb command "next" can bring us to upper stack frame, like:
>   > <stdin>(1)<module>()->None

OK, but the change in that variable should be called out in the log
entry, so please add that, together with the explanation above.  Maybe
also add a comment before the variable to explain what it needs to
match.

> +*** New user option 'python-pdbtrack-kill-buffers'.
> +If nil, buffers opened during pdbtracking session is not killed when
                                                     ^^
"are", plural.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]