[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype
|
From: |
Eli Zaretskii |
|
Subject: |
Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add prototype to avoid warnings. |
|
Date: |
Thu, 14 Nov 2019 16:24:38 +0200 |
> From: Robert Pluim <address@hidden>
> Cc: Eli Zaretskii <address@hidden>
> Date: Thu, 14 Nov 2019 13:26:13 +0100
>
> Eli> ; * src/font.h (font_is_ignored): Add prototype to avoid
> warnings.
> Eli> ---
>
> Eli> extern bool font_match_p (Lisp_Object spec, Lisp_Object font);
> Eli> +extern bool font_is_ignored (const char *name, ptrdiff_t namelen);
> Eli> extern Lisp_Object font_list_entities (struct frame *, Lisp_Object);
>
> Eli> extern Lisp_Object font_get_name (Lisp_Object font_object);
>
> Hmm, with which compiler?
GCC 7.3.0.
> The definition of that function is just before its first use
The paranoid warning options used by the developers' build causes GCC
to complain about non-static functions that have no prototype in
scope.
> (and now we have two prototypes for that function, the other is in
> gtkutil.h).
That one should be removed, because gkutil.c (indirectly) includes
font.h, AFAICT.