emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Change module interface to no longer use GMP objects directl


From: Eli Zaretskii
Subject: Re: [PATCH] Change module interface to no longer use GMP objects directly.
Date: Thu, 05 Dec 2019 16:43:17 +0200

> From: Philipp Stephani <address@hidden>
> Date: Wed, 4 Dec 2019 21:31:42 +0100
> Cc: Philipp Stephani <address@hidden>, Andreas Schwab <address@hidden>,
>  Stefan Monnier <address@hidden>,
>  Emacs developers <address@hidden>
> 
> Since there were no more comments or objections, and all other points
> of discussion have been resolved, I've pushed a slightly modified
> version of the patch as 096be9c454. Except for extremely exotic
> architectures or custom GMP builds, the chosen limb should be the same
> as the default GMP limb.

Thanks.

However, this:

  #if ULONG_MAX == 0xFFFFFFFF
  typedef unsigned long long emacs_limb_t;
  # define EMACS_LIMB_MAX ULLONG_MAX
  #else
  typedef unsigned long emacs_limb_t;
  # define EMACS_LIMB_MAX ULONG_MAX
  #endif

seems to punish every 32-bit build of Emacs (and on MS-Windows even
the 64-bit builds, AFAIU).  Is there a reason for doing this?  Testing
for the native size of an 'unsigned long' data type is not
significantly more complicated than the above, and GMP goes with that
when it determines the type of mp_limb_t, AFAIK.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]