Re: [PATCH] pcase.el: Add type pattern

[Michael Heerdegen]

Adam Porter <address@hidden> writes:

> The (pcase-defmacro type) form expands to:
>
>   (progn
>     (defun type--pcase-macroexpander
>         (type)
>       ;; [long docstring omitted here]
>       `(pred
>         (pcase--flip cl-typep ',type)))
>     (define-symbol-prop 'type--pcase-macroexpander 'edebug-form-spec 'nil)
>     (define-symbol-prop 'type 'pcase-macroexpander 
> #'type--pcase-macroexpander))
>
> My understanding is that the autoload cookie causes the entire
> cl-macs.el file to be loaded when the type--pcase-macroexpander function
> is called, which then causes cl-lib to be loaded.  So an additional
> (require 'cl-lib) would be redundant.  However, as I said, there are
> nuances to autoloading that I haven't grokked yet, so I may be missing
> something.

You understand better than me at least... Ok, `pcase--macroexpand' finds
the expander function by looking at the symbol property, and when
compiling the pattern the expander function is called to expand and
"cl-macs" gets loaded.  That should be alright.

Michael.