Re: Failing to GC killed buffers considered harmful

[Pip Cet]

On Sun, Mar 29, 2020 at 2:22 PM Eli Zaretskii <address@hidden> wrote:
> This recent change on master:
> causes us to dump killed buffers in some cases.  Presumably, the call
> to GC right before we start pdumping fails to collect a killed buffer,
> and it ends up being dumped.  When we restore from emacs.pdump, an
> Emacs built with --enable-checking on a platform that uses mmap for
> buffer text aborts here:

Not in all cases, I'm afraid.

> We could, of course, remove the assertion, but then we are left with a
> dead buffer that will never be GC'ed, AFAIU, because objects that come
> from the portable dump are considered constantly marked.

The same is true of all other objects, though, right? It seems like
it's simply a bad assert to me.

The problem appears to be that "all_buffers" points to a killed
buffer, and is remembered by pdumper.