[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Failing to GC killed buffers considered harmful
From: |
Eli Zaretskii |
Subject: |
Re: Failing to GC killed buffers considered harmful |
Date: |
Tue, 31 Mar 2020 17:09:32 +0300 |
> From: Stefan Monnier <address@hidden>
> Date: Mon, 30 Mar 2020 14:32:30 -0400
> Cc: Eli Zaretskii <address@hidden>, Daniel Colascione <address@hidden>,
> address@hidden
>
> > FWIW, maybe we should get rid of all_buffers.
> > AFAICT the only reason we need it is to unmark the buffers during the
> > sweep phase, and we could allocate buffers like any other
> > pseudovector instead.
>
> The patch below seems to work.
>
> The only worrisome part I think is that `live_buffer_holding` allowed
> pointers into buffer objects, whereas `live_vector_p` only treats
> pointers to the beginning of the object as a valid reference.
>
> Not sure why buffers would be more likely to have valid pointers into
> them (and can't remember discussions about that either)
Pointers to buffer text come to mind.
> - if (!pdumper_object_p (buffer))
> - XUNMARK_VECTOR (buffer);
Why is this part being removed?
Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/30
- Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/30
- Re: Failing to GC killed buffers considered harmful, Eli Zaretskii, 2020/03/30
- Re: Failing to GC killed buffers considered harmful, Daniel Colascione, 2020/03/30
- Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/30
- Re: Failing to GC killed buffers considered harmful, Eli Zaretskii, 2020/03/31
Re: Failing to GC killed buffers considered harmful,
Eli Zaretskii <=
Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/31
Re: Failing to GC killed buffers considered harmful, Pip Cet, 2020/03/31
Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/31
Re: Failing to GC killed buffers considered harmful, Pip Cet, 2020/03/31
Re: Failing to GC killed buffers considered harmful, Stefan Monnier, 2020/03/31