[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix display box cursor under image with margins
From: |
Clément Pit-Claudel |
Subject: |
Re: [PATCH] Fix display box cursor under image with margins |
Date: |
Sat, 25 Apr 2020 09:19:23 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 25/04/2020 06.35, Eli Zaretskii wrote:
>> From: Evgeny Zajcev <address@hidden>
>> Date: Sat, 18 Apr 2020 21:05:16 +0300
>> Cc: emacs-devel <address@hidden>
>>
>> > Here is the patch to fix issue making cursor hollow under non-mask image,
>> but containing margins.
>> This
>> > patch keeps box cursor to be box in case image has margins.
>>
>> Could you please give an example of such an image and what the results
>> look like, before and after the patch? It's hard to understand the
>> details of this otherwise.
>>
>> Here is first screenshot how hollow cursor looks on image with margin -
>> http://lgarc.narod.ru/pics/emacs-hollow-cursor.png
>>
>> And here is how it looks with patch applied -
>> http://lgarc.narod.ru/pics/emacs-box-cursor.png
>>
>> Without patch, look of the cursor won't change, it will remain being hollow
>
> Thanks. Frankly, I'm not sure the change is for the better.
>
> Does anyone else have an opinion?
I'm not sure I understood the patch fully; it seems to be about displaying two
lines instead of a box? If so, I think I prefer the box (but generally
speaking, respecting the cursor shape would be ideal (using a bar when the
cursor is a bar, and replacing the background of the image when the cursor is a
box)