emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: project.el: git submodules?


From: Dmitry Gutov
Subject: Re: project.el: git submodules?
Date: Fri, 15 May 2020 22:17:11 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

Hi Kevin!

On 15.05.2020 10:40, Kévin Le Gouguec wrote:

I've tried commit 779bc886:

✓ within "nested" projects (e.g. when $HOME is under version control,
   and visiting the Emacs repo under ~/src/emacs), project-find-file uses
   the innermost project (~/src/emacs) as root,

✓ at the root of a Git worktree (e.g. when ~/src/emacs-26.3 is a
   worktree of ~/src/emacs, and visiting ~/src/emacs-26.3),
   project-find-file uses the worktree (~/src/emacs-26.3) as root,

     ❌ in a subfolder of a Git worktree (e.g. in ~/src/emacs-26.3/src),
       project-find-file signals:

project-try-vc: Opening input file: No such file or directory, 
/home/$USER/src/emacs-26.3/src/.git

✓ at the root of a Git submodule (e.g. when ~/projects/foo/bar is a
   submodule of ~/projects/foo, and visiting ~/projects/foo/bar),
   project-find-file uses the parent module (~/projects/foo) as root,

     ❌ in a subfolder of a Git submodule (e.g. in
       ~/projects/foo/bar/baz), project-find-file signals:

project-try-vc: Opening input file: No such file or directory, 
/home/$USER/projects/foo/bar/baz/.git

Thank you for exhaustive testing. The failing cases should be fixed now.

I hope I got that right.  Thank you for working on this; I'd love for
project-find-file to finally work in worktrees :)

I was not aware they didn't. :-( Apparently I've been using the old, "fake" version of worktrees.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]