[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to b
From: |
Stefan Monnier |
Subject: |
Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered |
Date: |
Fri, 05 Jun 2020 09:58:57 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> Fix Arabic shaping when eww/shr fill the text to be rendered
> * src/hbfont.c (hbfont_shape): Don't use DIRECTION if the current
> buffer has bidi reordering disabled. (Bug#41005)
[...]
> - if (!NILP (direction))
> + if (!NILP (direction)
> + /* If they bind bidi-display-reordering to nil, the DIRECTION
> + they provide is meaningless, and we should let HarfBuzz guess
> + the real direction. */
> + && !NILP (BVAR (current_buffer, bidi_display_reordering)))
Hmm... so indeed I see that SHR binds `bidi-display-reordering`.
Isn't that a problem, since its docstring says:
[...]
Setting this to nil is intended for use in debugging the display code.
[...]
Can we change SHR so it doesn't bind this var?
Stefan
- Re: emacs-27 30a7ee5: Fix Arabic shaping when eww/shr fill the text to be rendered,
Stefan Monnier <=