Re: master 80abaea: Use lexical-binding in lunar.el and add tests

[Stefan Kangas]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> I'm seeing the following test failure:

Thanks for pointing this out.

> Test lunar-test-phase-list condition:
>     (ert-test-failed
>      ((should
>        (equal
>       (lunar-phase-list 3 1871)
>       '...))
>       :form
>       (equal
>        ((... "9:03pm" 0 "")
>       (... "11:46pm" 1 "**  Eclipse **")
>       (... "7:20am" 2 "")
>       (... "10:57pm" 3 "**  Eclipse possible **")
>       (... "12:06pm" 0 "")
>       (... "4:49pm" 1 "")
>       (... "3:57pm" 2 "")
>       (... "7:29am" 3 "")
>       (... "3:46am" 0 "")
>       (... "6:02am" 1 ""))
>        ((... "11:03pm" 0 "")
>       (... "1:46am" 1 "**  Eclipse **")
>       (... "9:20am" 2 "")
>       (... "12:57am" 3 "**  Eclipse possible **")
>       (... "2:06pm" 0 "")
>       (... "6:49pm" 1 "")
>       (... "5:57pm" 2 "")
>       (... "9:29am" 3 "")
>       (... "5:46am" 0 "")
>       (... "8:02am" 1 "")))
>       :value nil :explanation
>       (list-elt 0
>               (list-elt 1
>                         (arrays-of-different-length 6 7 "9:03pm" "11:03pm" 
> first-mismatch-at 0)))))
>    FAILED  5/5  lunar-test-phase-list (0.000611 sec)

Hmm, so there is a difference of two hours.

Yet I attempt to set the timezone like this in the tests:

  `(let ((calendar-latitude 40.1)
         (calendar-longitude -88.2)
         (calendar-location-name "Urbana, IL")
         (calendar-time-zone -360)
         (calendar-standard-time-zone-name "CST")
         (calendar-time-display-form '(12-hours ":" minutes am-pm)))

Does anyone see if I'm missing to set something important here?

> In case it matters, my time zone is
>
>    (format-time-string "%Z %z") ; => "IST +0100"

Here, I have:

(format-time-string "%Z %z") ; => "CEST +0200"

Which does not make it clearer to me why we have a two hour
difference...

Best regards,
Stefan Kangas