Re: eww and bookmarks

[Basil L. Contovounesios]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> > +(defcustom bookmark-eww-browse-url-function #'eww-browse-url
>> > +  "Doc..."
>> > +  :type '(choice
>> > +          (function-item eww-browse-url :doc "Use eww")
>> > +          (const :tag "Use value of `browse-url-browser-function'" nil)
>> > +          function))
>>
>> Isn't it strange having a boookmark-... variable defined in eww.el?
>
> Yes.  OTOH I wanted to avoid the risk of confusion with eww bookmarks
> and not call it "eww-bookmark-...".  Suggestions?

Is the proposed bookmark.el support not meant to supersede EWW's current
bookmark system?

Anyway, what about eww-browse-bookmark-function?

>> > +(defun eww--bookmark-title (title-string)
>> > +  (replace-regexp-in-string
>> > +   "\\` +\\| +\\'" ""
>> > +   (replace-regexp-in-string "[\n\t\r]" " " title-string)))
>>
>> Is the outer replace-regexp-in-string doing the same as string-trim?
>
> Is it?  I didn't touch that code, I only moved it for factoring.

That's what it looks like to me, but you can obviously leave it alone
for now.

>> > +(defun eww-bookmark-make-record  ()
>> > +  "Create an emacs bookmark record
>>                 ^^^^^
>>                 Capitalize
>
> Done.
>
>> > for an eww buffer.
>> >        ^^^
>> >        Upcase
>
> Is it ok to leave it downcased?

That's what Lars asked for, so yes.

-- 
Basil