[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use deactivate-mark from cua-cancel

From: Eli Zaretskii
Subject: Re: [PATCH] Use deactivate-mark from cua-cancel
Date: Sat, 20 Jun 2020 10:45:27 +0300

> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Sun,  7 Jun 2020 09:20:19 +0100
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> The reason is that with `cua-selection-mode` enabled, C-g now calls
> `cua-cancel` instead of `keyboard-quit`.  Currently `cua-cancel` looks
> like this:
>   (defun cua-cancel ()
>     "Cancel the active region, rectangle, or global mark."
>     (interactive)
>     (setq mark-active nil)
>     (if (fboundp 'cua--cancel-rectangle)
>         (cua--cancel-rectangle)))
> It is the line:
>     (setq mark-active nil)
> that is problematic, setting `mark-active` directly avoids the
> `deactivate-mark-hook`.  I think that instead we should be calling
> `deactivate-mark`, and this is what this patch does.

Thanks, pushed to the master branch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]