emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 1ecd350 2/2: Evaluate some unnecessarily quoted lambdas


From: Stefan Monnier
Subject: Re: master 1ecd350 2/2: Evaluate some unnecessarily quoted lambdas
Date: Sun, 21 Jun 2020 12:18:50 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> -     (lambda-code (byte-compile '(lambda ()))))
> +        (lambda-code (byte-compile (lambda ()))))

I can't believe I'm doing that, but: this hunk is wrong!

`byte-compile` takes source code as input, not values.  It does go to
the trouble of trying to handle the case where we pass it a function
value that's not yet compiled because it's an important use-case in
practice, but it's better to avoid it since the above means that we'll
first turn '(lambda () ()) into a closure object which `byte-compile`
then has to convert back to something like (lambda () ()).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]