[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Emacs doesn't compile -- what am I missing?
|
From: |
Eli Zaretskii |
|
Subject: |
Re: Emacs doesn't compile -- what am I missing? |
|
Date: |
Mon, 29 Jun 2020 14:39:33 +0300 |
|
User-agent: |
K-9 Mail for Android |
On June 29, 2020 2:25:03 PM GMT+03:00, David Kastrup <dak@gnu.org> wrote:
>
> I get
>
> In file included from ../../emacs/src/xfaces.c:225:
> ../../emacs/src/xfaces.c:922:8: error: ‘Fcolor_values_from_color_spec’
> undeclared here (not in a function); did you mean
> ‘Scolor_values_from_color_spec’?
> 922 | Fcolor_values_from_color_spec,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../emacs/src/lisp.h:3066:26: note: in definition of macro ‘DEFUN’
> 3066 | { .a ## maxargs = fnname }, \
> | ^~~~~~
> ../../emacs/src/xfaces.c:922:8: warning: no previous prototype for
> ‘Fcolor_values_from_color_spec’ [-Wmissing-prototypes]
> 922 | Fcolor_values_from_color_spec,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../emacs/src/lisp.h:3068:16: note: in definition of macro ‘DEFUN’
> 3068 | Lisp_Object fnname
> | ^~~~~~
>
> Which would suggest a problem with
>
> commit 30ff2433b16dba2c4e36c6eda6f808c6f2cb46d1
> Author: Eli Zaretskii <eliz@gnu.org>
> Date: Mon Jun 22 18:32:01 2020 +0300
>
> Minor improvements as followup to recent RGB string-parsing change
>
> * src/xfaces.c (Finternal_color_values_from_color_spec): Rename to...
> (Fcolor_values_from_color_spec): ...this. Callers changed.
> Rename the argument to SPEC and improve the doc string.
> (parse_color_spec, parse_float_color_comp, parse_hex_color_comp):
> Improve commentary.
> (parse_color_spec): Rename the argument S to SPEC.
>
> * etc/NEWS: Mention 'color-values-from-color-spec'.
>
> But it seems extremely unlikely that a problem causing compilation to
> fail would persist for a week.
>
> Ideas?
Some snafu with globals.h?