[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add support for parsing column numbers in Visual Studio mess
From: |
Daniel Martín |
Subject: |
Re: [PATCH] Add support for parsing column numbers in Visual Studio messages |
Date: |
Sun, 26 Jul 2020 22:57:01 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (darwin) |
Mattias Engdegård <mattiase@acm.org> writes:
> 26 juli 2020 kl. 17.22 skrev Daniel Martín <mardani29@yahoo.es>:
>
>> The problem seems to happen because the regular expression for MSVC in
>> compile.el doesn't take into account column numbers. Attached is a proposed
>> patch to implement support for it.
>
> Thank you! This looks all right. Can you confirm that the column numbering
> works like in GCC -- ie, the leftmost column is 1, not 0?
Yes, it works like in GCC, so I don't think it needs further adjustment.
BTW, could you send me the FSF copyright assignment form? I may
contribute some substantial work to Emacs in the future. Thanks.
--
Daniel Martín