Re: master 527413f: Go back to not using custom-push-theme when enabling a theme

[Stefan Monnier]

>     Go back to not using custom-push-theme when enabling a theme
>     
>     * lisp/custom.el (enable-theme): Relying on custom-push-theme to
>     handle theme settings and prior user settings was a mistake.  The
>     theme settings haven't changed between loading the theme and enabling
>     it, so we don't need all of what custom-push-theme does.  However, we
>     still need to save a user setting outside of Customize, in order to be
>     able to get back to it, so do that in enable-theme itself.

Hi, could you explain what's the motivation behind this change?
Is it an optimization (i.e. with hopefully no visible effect), or does
it fix an actual problem?  If it fixes an actual problem, could you try
and add a corresponding regression test for it?


        Stefan