emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-


From: Basil L. Contovounesios
Subject: Re: master aea9365 3/3: * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
Date: Fri, 06 Nov 2020 21:33:33 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Mattias Engdegård <mattiase@savannah.gnu.org> writes:
>
>> branch: master
>> commit aea936562b033899f0b7160cc492bbea1006863b
>> Author: Mattias Engdegård <mattiase@acm.org>
>> Commit: Mattias Engdegård <mattiase@acm.org>
>>
>>     * lisp/gnus/gnus-search.el (gnus-search-contact-tables): Fix type.
>>     
>>     A more precise type is desirable but at it is now correct ('list' is 
>> not).
>> ---
>>  lisp/gnus/gnus-search.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el
>> index 15d96e3..7ee7c53 100644
>> --- a/lisp/gnus/gnus-search.el
>> +++ b/lisp/gnus/gnus-search.el
>> @@ -410,7 +410,7 @@ returned by `completion-at-point-functions'.  That 
>> usually means
>>  a list of strings, a hash table, or an alist."
>>    :group 'gnus-search
>>    :version "28.1"
>> -  :type 'list)
>> +  :type '(repeat sexp))
>
> Doesn't this type demand a list of lists? It could also be a list of
> hashtables, or functions, or a mix of alist/list/function/hashtable...

A sexp in this context is "any Lisp object that can be printed and read
back".  That covers most completion table types, right?  AFAICT the only
type more general than that is restricted-sexp.

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]