[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] Add gc-estimated-time variable
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 1/3] Add gc-estimated-time variable |
Date: |
Wed, 18 Nov 2020 19:45:09 +0200 |
> From: Spencer Baugh <sbaugh@catern.com>
> Date: Tue, 17 Nov 2020 19:20:48 -0500
> Cc: Spencer Baugh <sbaugh@catern.com>
>
Thanks, a few comments regarding style and coding conventions:
> if (FLOATP (Vgc_elapsed))
> {
> + const struct timespec this_gc_elapsed = timespec_sub (current_timespec
> (), start);
Please avoid such long lines, break them into several shorter lines.
> + if (gc_time_ema == 0.0) {
> + /* initialize exponential moving average to first GC time */
> + gc_time_ema = timespectod (this_gc_elapsed);
> + } else {
> + /* decay very fast, since heap size can change rapidly */
> + gc_time_ema = 0.5 * gc_time_ema + 0.5 * timespectod
> (this_gc_elapsed);
> + }
This is not our style of using braces, please reformat to use our
style.
- Eager garbage collection, sbaugh, 2020/11/15
- Re: Eager garbage collection, Stefan Monnier, 2020/11/17
- Re: Eager garbage collection, Spencer Baugh, 2020/11/17
- Re: Eager garbage collection, Stefan Monnier, 2020/11/17
- Re: Eager garbage collection, Andrea Corallo, 2020/11/18
- Re: Eager garbage collection, Eli Zaretskii, 2020/11/18
- Re: Eager garbage collection, Andrea Corallo, 2020/11/18
- Re: Eager garbage collection, Eli Zaretskii, 2020/11/18
- Re: Eager garbage collection, Andrea Corallo, 2020/11/18