emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: scratch/command 064f146 1/2: Change command to interactive ... modes


From: Lars Ingebrigtsen
Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes
Date: Sat, 20 Feb 2021 16:01:24 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> You'll need to adjust the Edebug specs of `defun` (there are probably
>>> other ways, of course) if you want to fix that.
>> You mean add "future-interactive" as an alternative in the spec?
>
> Yup: the spec is all about instrumenting the source code as-is (before
> macro-expansion).

OK, so if we do include future-interactive as a core GNU ELPA package,
then the following 100% guaranteed untested patch should make this work
in Emacs 28.

diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 45e76c751f..8a5960bb28 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -2088,7 +2088,8 @@ edebug-match-def-body
        ;; more convenient to define their Edebug spec here.
        (defun ( &define name lambda-list lambda-doc
                [&optional ("declare" def-declarations)]
-               [&optional ("interactive" &optional [&or stringp def-form]
+               [&optional ([&or "interactive" "future-interactive"]
+                            &optional [&or stringp def-form]
                             &rest symbolp)]
                def-body))
 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



reply via email to

[Prev in Thread] Current Thread [Next in Thread]