Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

Hi Stefan & Basil,

>> My question is, which combination of the following should happen:
>> - The completion-predicate properties are not autoloaded.
>
> This means that autoloaded functions will always be listed in `M-x`
> (except after loading the corresponding package), which is undesirable.

Calling `tramp-crypt-add-directory' interactively is the only way to
activate package tramp-crypt.el. As long as the package isn't loaded
yet, this command must be visible.

>> - The function tramp-crypt-enabled-p is autoloaded.
>
> Sounds good.

No, because otherwise tramp-crypt.el would be loaded unconditionally due
to the command completion of `tramp-crypt-enabled-p'.

>> - The function command-completion-default-include-p checks whether
>>   completion-predicate is functionp.
>
> I think this is *also* needed, tho a better option is
> `with-demoted-errors` since no matter what error is signal'd we don't
> want it to prevent `M-x` from doing its job.

Yes.

I have adapted tramp-crypt.el such a way, that `completion-predicate'
for `tramp-crypt-add-directory' is set only after loading tramp-crypt.el.

>         Stefan

Best regards, Michael.