Re: Lazy wdired preprocessing - Question

[Arthur Miller]

Arthur Miller <arthur.miller@live.com> writes:

Typical me; it was my init file requiring my old working file. Fixed.
Works fine for me now :-).

> Arthur Miller <arthur.miller@live.com> writes:
>
> I have forgott to say, I did make use make bootstrap before
> building Emacs.
>
>> I hope I don't bother, too much.
>>
>> There is some problem I see when building Emacs with the patch:
>>
>> It builds fine, but when I test it, it seems that I need to re-eval
>> after Emacs started wdired.el in order to get it to work properly. What
>> happeneds it that Emacs seems to run self-insert command upon entering
>> wdired mode anyway, despite being build with patched wdired. 
>>
>> However when I eval my working file "lazy-wdired.el" it works fine. The
>> code is identical as one in the patch.
>>
>> I also noticed when I unload-feature lazy-wdired, so I unload all those
>> wdired definitions, and if I eval patched wdired.el from lisp directory 
>> which I
>> built Emacs with, everything also works correctly too.
>>
>> I am little bit confused, why do I need to re-evaluate wdired.el in a
>> freshly patched and recompiled Emacs to get this to work? 
>>
>>
>>
>> -------------------- Start of forwarded message --------------------
>> From: Arthur Miller <arthur.miller@live.com>
>> To: emacs-devel@gnu.org
>> Subject: Patch: Lazy wdired preprocessing
>> Date: Tue, 23 Mar 2021 15:52:08 +0100
>>
>> The original thread seems to have become more of a lisp language thread,
>> so to make it easier, I made a new one, with more descriptive name.
>>
>> Attached is new a version of patch. Seems to correctly work with
>> permissions now. I have also discovered (current-column) function so I
>> no longer calculate columns in my own code :-).
>>
>> I have tested on my ext4 file system where my normal system is
>> installed, and there it works correctly.
>>
>> I have also tested on one NTFS drive, where I can not change permissions
>> normally and there is following behaviour, don't know if it is
>> acceptable or not:
>>
>> In wdired buffer I can seemingly change permission, but when I save
>> buffer, then permission is of course not saved and reverted dired buffer
>> shows correct permission. In Dolphin, it seems to work similar (I can
>> set pulldown menu in permissions dialog to only read, and press OK, but
>> it is not saved).
>>
>> There is also a question what happeneds when one have an empty folder
>> and switches to wdired buffer. I don't see it handled in old wdired, so
>> I have added an error condition for that in
>> wdired-change-to-wdired-mode.
>>
>> Please test it, there might be some other test condition I haven't
>> tested. I am attaching both the working file for easy evaluation and
>> test, and the patch.
>>
>> best regards
>> /a
>>
>>
>>
>> -------------------- End of forwarded message --------------------