emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables


From: Stefan Monnier
Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables
Date: Thu, 25 Mar 2021 12:48:53 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> I'd prefer to pick up where we left off back then.  The main issue
> left unresolved in the past discussion was the potential slowdown of
> simple accesses to buffer-local vars due to your proposal.  Can we
> please have benchmarks for that, so we could decide whether the
> tradeoff is worth it?  It's quite possible that the performance
> aspects could affect the code changes, so even uncontroversial
> cleanups should perhaps wait until we have figured out the more
> important aspects of these changesets.

I think those changes are good to go and fundamentally unrelated to
the discussion (except to the extent that they were found while
investigating that part of the code).

Of course, they may not be the final word, but I'd rather install those
now so they don't get lost if the rest of the discussion ends up not
going anywhere and also so the rest of the discussion doesn't need to be
using patches relative to code that's not in `master`.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]