Re: [PATCH] Lazy wdired preprocessing

[Michael Heerdegen]

Arthur Miller <arthur.miller@live.com> writes:

> This was re-implementation of parts of wdired to make it more efficient
> and faster to enter the wdired mode.

Ok, thanks for the elaboration.  Didn't try it yet, but I welcome this
change.  So far I have one question:

+  ;; find one column with permissions and set permision text boundaries
+  (save-excursion
+    (goto-char (point-min))
+    (unless (re-search-forward dired-re-perms nil t 1)
+      (wdired-abort-changes)
+      (error "No files to be renamed - Exiting to Dired mode."))
+    (goto-char (match-beginning 0))
+    (setq-local wdired-perm-beg (current-column))
+    (goto-char (match-end 0))
+    (setq-local wdired-perm-end (current-column)))

Did you check that this works when `dired-hide-details-mode' is enabled?
I ask because AFAIK `current-column' doesn't count invisible characters.
[It might be better to just count characters from the line's beginning,
but I see that the existing code also uses `current-column'.]

Thanks,

Michael.