Re: Simple isearch concerns

[Juri Linkov]

>>> 3. The after change hook should call `isearch-update' instead of
>>>    `isearch-search-and-update' after `previous-history-element' and few
>>>    other commands.  In isearch-mb I use a symbol property to keep track
>>>    of this.
>>
>> Thanks, it seems many solutions could be taken from isearch-mb to
>> isearch.el.
>
> Actually, since I thought this thing through already, I would be happy
> to provide a patch implementing the minibuffer-controlled isearch.

It would be nice if your experience with the minibuffer-controlled isearch
could help to bring the same feature to isearch.el.

> May I suggest that you merge just the `isearch-buffer-local' change at
> this point, and then wait for my patch doing the minibuffer part?

Testing shows that the `isearch-buffer-local' change works fine,
with only one deficiency: as (info "(elisp) Searching Keymaps") says
get-char-property takes precedence over emulation-mode-map-alists.

This means that typing isearch characters when point is e.g.
on a Gnus attachment line, typing a character like 'o' bound
to 'gnus-mime-save-part' will exit isearch and run this command.

I see no way to workaround this limitation.

> Actually, in the patch attached to
> https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg01359.html
> (which by the way, do you think we can merge it?)

Before merging I tried to check if it covers everything discussed in
bug#11378.