Re: [WIP PATCH] Controlling Isearch from the minibuffer

[Juri Linkov]

> - Does the approach taken here seem sufficiently robust?  Note in
>   particular the `with-isearch-window' macro, which is now needed around
>   several functions,

You can avoid the with-isearch-window macro by checking
in isearch-pre-command-hook if the current buffer is the minibuffer,
then switch to the original buffer, and let the isearch command to
do what it normally does, then switch back to the minibuffer
in isearch-post-command-hook.

>   as well as the somewhat hacky `run-with-idle-timer'
>   call inside the `isearch-mode' function.

You can avoid the timer hack by adding a guard to
isearch-post-command-hook: when at the end of the isearch command,
point is not in the minibuffer, activate the minibuffer
(assuming that isearch-from-minibuffer is t).

> - Are the slightly backwards incompatible keybinding changes in
>   `isearch-edit-string' acceptable?

Only when isearch-from-minibuffer is t.

> - I don't like the `with-isearch-window-quitting-edit' macro, but I
>   don't see a different way of achieving the necessary effect.

The with-isearch-window-quitting-edit macro can be avoided the same way
as the with-isearch-window macro.