Re: master 344f769: Add support for using a TLS client certificate with 'erc-tls' (bug#47788)

[Michael Albinus]

bandali@gnu.org (Amin Bandali) writes:

Hi,

> diff --git a/doc/misc/erc.texi b/doc/misc/erc.texi
> index d635cac..45a753d 100644
> --- a/doc/misc/erc.texi
> +++ b/doc/misc/erc.texi

> +@example
> +(erc-tls :server "chat.freenode.net" :port 6697
> +         :client-certificate t)
> +@end example
> +
> +In the case of @code{:client-certificate t}, you will need to add a
> +line like the following to your authinfo file
> +(e.g. @file{~/.authinfo.gpg}):
> +
> +@example
> +machine chat.freenode.net key /home/bandali/my-cert.key cert 
> /home/bandali/my-cert.crt
> +@end example
> +@end defun

This explains the .authinfo/.netrc case. But auth-source knows more
backends, how are they supported? I guess, this question must be
answered by the auth Info manual, so I would recommend a reference to
that manual.

> diff --git a/etc/NEWS b/etc/NEWS
> index 6fe4e98..34aeaf0 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS

> +To use a certificate with 'erc-tls', specify the ':client-certificate'
> +optional parameter, whose value should be as described in the
> +documentation of 'open-network-stream': if non-nil, it should either
> +be a list where the first element is the file name of the private key
> +corresponding to a client certificate and the second element is the
> +file name of the client certificate itself to use when connecting over
> +TLS, or t, which means that 'auth-source' will be queried for the
> +private key and the certificate.
> +
> +Examples of use:
> +
> +    (erc-tls :server "chat.freenode.net" :port 6697
> +             :client-certificate
> +             '("/home/bandali/my-cert.key"
> +               "/home/bandali/my-cert.crt"))
> +
> +    (erc-tls :server "chat.freenode.net" :port 6697
> +             :client-certificate
> +             `(,(expand-file-name "~/cert-freenode.key")
> +               ,(expand-file-name "~/cert-freenode.crt")))
> +
> +    (erc-tls :server "chat.freenode.net" :port 6697
> +             :client-certificate t)
> +
> +In the case of ':client-certificate t', you will need to add a line
> +like the following to your authinfo file (e.g. "~/.authinfo.gpg"):
> +
> +    machine chat.freenode.net key /home/bandali/my-cert.key cert 
> /home/bandali/my-cert.crt

I believe, this is too much / too detailed for etc/NEWS. A reference to
the ERC Info manual would be better.

Best regards, Michael.