emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio


From: Daniel Mendler
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7)
Date: Thu, 20 May 2021 11:39:41 +0200

On 5/13/21 1:45 PM, Daniel Mendler wrote:
> On 5/13/21 12:32 PM, Eli Zaretskii wrote:
>>> I attached the updated patches, the variable `completions-group-sort`
>>> allows the more user friendly values nil and 'alphabetical. I hope it is
>>> more acceptable in this form.
>>
>> Thanks, this addresses my concerns.
>>
>> (Please proofread the comments, doc strings, and Texinfo changes in
>> the patches to make sure you leave 2 spaces between sentences, per our
>> conventions to use US English.)
> 
> Thank you, Eli. I went over the commit messages, comments, Texinfo and
> doc strings and made a few corrections. The revised patches are attached.

>From my side the attached patches are ready. Is there anything else that
should be addressed? Juri, does the `group-function` work as desired for
`ucs-char-names` in the current form? See my last mail "REVISED PATCH
VERSION 7".

Thank you!

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]