emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh)


From: Jason Kim
Subject: Re: Small shell-mode patch to handle auto-cd (e.g. shells like zsh)
Date: Mon, 24 May 2021 10:15:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2

Sorry for the delay in response!
Thank you (especially to Eli!) for your guidance.

I set :version to "28", but I don't see an issue with applying this patch to earlier versions.

All of the nits are I think fixed.

Please find enclosed new format-patch patch.

Thanks again!
-Jason

On 5/15/21 1:20 AM, Eli Zaretskii wrote:
Cc: emacs-devel@gnu.org, shivers@cs.cmu.edu, jason.kim@revtera.com
From: Jason Kim <jason.w.kim@icloud.com>
Date: Fri, 7 May 2021 09:51:08 -0700

Hi, enclosed is what I hope is an acceptable git-format-patch for this
tiny change.

If not, please let me know how to fix!

Applying these patches produces the following byte-compilation
warnings:

    ELC      shell.elc

  In toplevel form:
  shell.el:324:1: Warning: defcustom for `shell-has-auto-cd' fails to specify
      type
  shell.el:324:1: Warning: custom-declare-variable `shell-has-auto-cd' docstring
      wider than 80 characters

In addition, please provide a :version tag for the new defcustom.

And finally, the commit log message should include ChangeLog-style
description of the file(s) and functions/variables which were affected
by the changes, see the existing log messages and the advice in
CONTRIBUTE for more details.

Please fix those minor nits, and then we will be able to install the
changes.

Thanks.

Attachment: 0001-Auto-cd-support-for-lisp-shell.el.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]